Change in ovirt-engine-sdk[master]: sdk: Manually fix type of disk snapshots

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Feb 25 09:27:44 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: sdk: Manually fix type of disk snapshots
......................................................................


sdk: Manually fix type of disk snapshots

Currently the RSDL generator of the engine doesn't report correctly the
type of disk snapshots collection, it reports "BaseResource" instead of
"DiskSnapshot". The current version of the generator doesn't have a
problem with this, because it doesn't use this information (it
calculates it from the collection type, using plural to singular rules).
But the new version of the generator will stick to the reported
information, and will generate wrong code. To avoid this issue this
patch fixes the type manually. The issue will be fixed in the engine by
the following change:

  http://gerrit.ovirt.org/37755

Change-Id: I1e2d046c9f10f5bd7576671ec29b31e1a2799ce5
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/resources/rsdl.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/37864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e2d046c9f10f5bd7576671ec29b31e1a2799ce5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list