Change in ovirt-engine[master]: engine: Correct user connected/disconnected messages

ahadas at redhat.com ahadas at redhat.com
Wed Feb 25 13:21:00 UTC 2015


Arik Hadas has submitted this change and it was merged.

Change subject: engine: Correct user connected/disconnected messages
......................................................................


engine: Correct user connected/disconnected messages

Message 'User disconnected' was added to Action Log when user had
connected to a VM and vice versa.

The bug was in VdsEventListener.processOnClientIpChange() method called
from VmsMonitoring.afterVMsRefreshTreatment() method.
processOnClientIpChange() was reading the client IP from DB, but IP
address of the currently connecting client is written to DB after
calling this method (saveVmsToDb() call at the end of
afterVMsRefreshTreatment() method).

To correct this additional parameter was added to
processOnClientIpChange() method to pass IP address of the currently
connecting client.

Change-Id: Icce32619e3cc88f12e339b4eef5717f3d279e232
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
3 files changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Shmuel Leib Melamud: Verified
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/38070
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icce32619e3cc88f12e339b4eef5717f3d279e232
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list