Change in ovirt-engine[master]: core: Removing redundant method midifier

mlipchuk at redhat.com mlipchuk at redhat.com
Thu Jan 8 12:33:35 UTC 2015


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Removing redundant method midifier
......................................................................


core: Removing redundant method midifier

Removing public modifier in the StorageServerConnectionDAO interface.

Quoting from the JLS:
It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.

Change-Id: Ia0b950da2434379b2c23c6dc878bd613fbbef4b5
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit http://gerrit.ovirt.org/36666
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0b950da2434379b2c23c6dc878bd613fbbef4b5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list