Change in ovirt-engine[ovirt-engine-3.5]: core: Storage allocation validation fix on new VMs

tnisan at redhat.com tnisan at redhat.com
Thu Jan 8 16:17:34 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: Storage allocation validation fix on new VMs
......................................................................


core: Storage allocation validation fix on new VMs

In the current situation, allocation checks are done on the template
disk, which may be of the wrong storage type/format. Updating the
image's data to support the allocation validations.

Change-Id: I13f8585a04157a55528ad4331455c3f156bdb84b
Bug-Url: https://bugzilla.redhat.com/1179688
Bug-Url: https://bugzilla.redhat.com/1178021
Bug-Url: https://bugzilla.redhat.com/1179690
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommandTest.java
9 files changed, 110 insertions(+), 103 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Allon Mureinik: Looks good to me, approved
  Vered Volansky: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/36686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13f8585a04157a55528ad4331455c3f156bdb84b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list