Change in ovirt-engine[master]: engine: (Cleanup) Remove unused graphics attributes

ahadas at redhat.com ahadas at redhat.com
Sun Jan 11 09:41:00 UTC 2015


Arik Hadas has submitted this change and it was merged.

Change subject: engine: (Cleanup) Remove unused graphics attributes
......................................................................


engine: (Cleanup) Remove unused graphics attributes

Removes these attributes (and their persistence)
 - VmDynamic.display,
 - VmDynamic.displaySecurePort,
 - VmDynamic.displayIp,
 - VmDynamic.displayType
 as they are replaced with GraphicsInfo.

Moreover the patch adds graphics info to one row in fixtures (previously
forgotten).

todo
 - remove atts from vm static too (represented by vm devices)

Change-Id: Id4fbd37b2b41b7288f78b60f27427c7b666d83d4
Bug-Url: https://bugzilla.redhat.com/1033547
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ExtendedVmDynamic.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmTestPairs.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_06_0710_remove_deprecated_display_columns.sql
M packaging/dbscripts/vms_sp.sql
11 files changed, 23 insertions(+), 202 deletions(-)

Approvals:
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/31200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4fbd37b2b41b7288f78b60f27427c7b666d83d4
Gerrit-PatchSet: 68
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list