Change in ovirt-engine[master]: webadmin: system tab -> advanced starts unfolded

tjelinek at redhat.com tjelinek at redhat.com
Fri Jan 16 13:54:17 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: system tab -> advanced starts unfolded
......................................................................


webadmin: system tab -> advanced starts unfolded

The problem was that the adminOnlyWidgets() contained not only the expander
itself but also it's content showing it if the user is an admin user.

This is not correct - the visibility has to be controlled by the
AdvancedParametersExpander component only and this whole component has to be
shown/hidden using the adminOnlyWidgets()

Change-Id: Ib5778b4745cda6abd2648074d71f52548b75916e
Bug-Url: https://bugzilla.redhat.com/1166048
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/36887
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5778b4745cda6abd2648074d71f52548b75916e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list