Change in ovirt-engine[master]: webadmin: replace == to equals

tjelinek at redhat.com tjelinek at redhat.com
Tue Jan 27 11:18:07 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: replace == to equals
......................................................................


webadmin: replace == to equals

It is not a good practice to rely on the "==" even it mostly passes since:
- in production mode it translates to javascript and the "==" is ok there
- in devel mode the same strings are commonly represented inside the JVM as one
  object so it mostly passes.

But in java it is just not a good practice and it is not reliable

Change-Id: Ic5deb1807573fa9944ede7ea09650f68571e0d6d
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Lior Vernia: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/37310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5deb1807573fa9944ede7ea09650f68571e0d6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list