Change in ovirt-engine[ovirt-engine-3.5]: core: Leave free space value as null

tnisan at redhat.com tnisan at redhat.com
Thu Jan 29 15:55:48 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: Leave free space value as null
......................................................................


core: Leave free space value as null

In Some situations, such as a newly created disks or disks on a storage domain
that's been re-connected, the disk's free space -
StorageDomainDynamic.availableDiskSize is null. This was interpreted
into 0 in some cases, causing a strict reaction from the system, though
is doesn't necessarily means the storage has 0 space. These cases are now using the null value and
do not assume low space.
The value will be updated on the next poll from vdsm, making sure future
behaviour is as is should.

Change-Id: I3379f34c0022eb7066db400f9d9342f8d02fb85f
Bug-Url: https://bugzilla.redhat.com/1177147
Bug-Url: https://bugzilla.redhat.com/1182012
Related-To: https://bugzilla.redhat.com/1176854
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
3 files changed, 17 insertions(+), 17 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Vered Volansky: Verified



-- 
To view, visit http://gerrit.ovirt.org/37306
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3379f34c0022eb7066db400f9d9342f8d02fb85f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list