Change in ovirt-engine[master]: restapi: StorageDomainValidator checks wrong format parameter

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Jul 1 09:19:23 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: StorageDomainValidator checks wrong format parameter
......................................................................


restapi: StorageDomainValidator checks wrong format parameter

StorageDomainValidator checks if the parameter isFormat (Boolean) was
passed. If it was, it validates a different parameter, StorageFormat.
This patch fixes this issue so now StorageDomainValidator deals
only with StorageFormat, and removes the unused isFormat parameter
from all the signatures of /storagedomains|rel=add.

Change-Id: I6682008271bf9e58df8ee9971b1bdf596968cfcc
Bug-Url: https://bugzilla.redhat.com/1238119
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/StorageDomainValidator.java
2 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, approved; Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/43087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6682008271bf9e58df8ee9971b1bdf596968cfcc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list