Change in ovirt-engine[master]: packaging: sercon: fix copying of artifacts

sbonazzo at redhat.com sbonazzo at redhat.com
Fri Jul 3 06:28:50 UTC 2015


Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: sercon: fix copying of artifacts
......................................................................


packaging: sercon: fix copying of artifacts

Outside developer mode, it is wrong to copy artifacts
in the same transaction who creates them.
The copy will (obviously) fail, and no artifact at all
will be created.

It is better to create the artifact we need directly
in the final destination, and copy the others. We are
already in a trasaction, so this is safe as the previous
design, and proabably less confusing.

Change-Id: I5a8d7a4edb92a872f37f89a7aef1187b1a03a542
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py
1 file changed, 82 insertions(+), 78 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Looks good to me, but someone else must approve
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/42742
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a8d7a4edb92a872f37f89a7aef1187b1a03a542
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list