Change in mom[master]: guest manager: single-thread monitoring

alitke at redhat.com alitke at redhat.com
Mon Jul 13 18:55:29 UTC 2015


Adam Litke has submitted this change and it was merged.

Change subject: guest manager: single-thread monitoring
......................................................................


guest manager: single-thread monitoring

So far MOM used one thread per Guest Monitor.
The two main reasons were
- to minimize interference between VMs
- the lack of a suitable bulk API (especially from libvirt).

However, when running inside VDSM, MOM can leverage
the safety which VDSM provides, and its bulk APIs.
Moreover, libvirt recently gained bulk APIs as well.

This patch changes the internals of Guest Manager to
fully decouple Guest Monitor and threads.
It is still possible to run one thread per Guest Monitor
as before, but it is now possible to mix and match
threads and monitors with complete freedom.

This change paves the road for better and more efficient
integration with VDSM. In that case, we want to be able
to run all the MOM monitoring with just one thread.

Change-Id: I96b96fef0c0c42fd45b76754da9c629865ab1954
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/37826
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Sivák <msivak at redhat.com>
---
M doc/mom-balloon+ksm.conf
M doc/mom-balloon.conf
M mom/GuestManager.py
M mom/__init__.py
4 files changed, 65 insertions(+), 9 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/37826
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96b96fef0c0c42fd45b76754da9c629865ab1954
Gerrit-PatchSet: 18
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list