Change in ovirt-engine[master]: core: Remove useless DbFacade mocking

amureini at redhat.com amureini at redhat.com
Tue Jul 14 13:36:39 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove useless DbFacade mocking
......................................................................


core: Remove useless DbFacade mocking

Removed useless mocking of DbFacade from
AddExistingBlockStorageDomainCommandTest. The DAOs are mocked directly,
and mocking the DbFacade does nothing but redundantly expose
implementation details to the test.

Change-Id: I47338c264b8ea9392f1ef4dd939727b94cefb158
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/43573
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I47338c264b8ea9392f1ef4dd939727b94cefb158
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list