Change in ovirt-engine[master]: core: Remove useless DbFacade mocking

amureini at redhat.com amureini at redhat.com
Tue Jul 14 13:37:44 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove useless DbFacade mocking
......................................................................


core: Remove useless DbFacade mocking

Removed useless mocking of DbFacade from
StorageHandlingCommandBaseTest. The DAOs are mocked directly,
and mocking the DbFacade does nothing but redundantly expose
implementation details to the test.

Change-Id: I4dd520dbf7fa5907b22bc6053b1658e316dfc84c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java
1 file changed, 8 insertions(+), 15 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/43574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4dd520dbf7fa5907b22bc6053b1658e316dfc84c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list