Change in ovirt-engine[master]: core: get down vm from monitoring also on power off

ofrenkel at redhat.com ofrenkel at redhat.com
Tue Jul 28 05:24:22 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: core: get down vm from monitoring also on power off
......................................................................


core: get down vm from monitoring also on power off

currently power off flow assume vm will not be reported by vdsm anymore,
and set vm to down and call processDownVm directly.
this is not always true:
* if it takes some time to vdsm to destroy the vm
 the vm might be reported as down on monitoring cycle.
* when using events - event with status down in received.

so changed DestroyVmVDSCommand to set the vm to powering down, and down
will be received from the monitoring.
also changed the monitoring to allow vm in Powering Down status not to
be reported anymore, and treat as normal down (and not error).

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242500
Change-Id: Ic60cceac6ad71adcb4d96a8938f98b5ea08f2043
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
2 files changed, 11 insertions(+), 16 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43905
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic60cceac6ad71adcb4d96a8938f98b5ea08f2043
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list