Change in ovirt-engine[master]: core: Extract DuplicateKeysChecks#loadFileFromPath

amureini at redhat.com amureini at redhat.com
Wed Jul 29 11:54:11 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Extract DuplicateKeysChecks#loadFileFromPath
......................................................................


core: Extract DuplicateKeysChecks#loadFileFromPath

Extract the common code in the various tests to a utility method that
load a properties file from a relative path.

Change-Id: I05406cacf6cf9379aab969772205aaa395f38783
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/DuplicateKeysTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/DuplicateKeysTest.java
4 files changed, 18 insertions(+), 27 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/43918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05406cacf6cf9379aab969772205aaa395f38783
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list