Change in ovirt-engine[master]: core: PropertiesTestUtils -> AbstractPropertiesTestBase

amureini at redhat.com amureini at redhat.com
Wed Jul 29 12:12:28 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: PropertiesTestUtils -> AbstractPropertiesTestBase
......................................................................


core: PropertiesTestUtils -> AbstractPropertiesTestBase

Converted PropertiesTestUtils to AbstractPropertiesTestBase as the tests
using it were just copy-pasting the content except for the path.
Converting PropertiesTestUtils to AbstractPropertiesTestBase allows us
to move the actual tests there, and have each concrete class just extend
it and specify the path.

Change-Id: I129dbfab8590fc6b6cecd054ac63a7c2d84be812
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/ErrorMessagesTest.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ErrorMessagesTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ErrorMessagesTest.java
4 files changed, 32 insertions(+), 57 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43920
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I129dbfab8590fc6b6cecd054ac63a7c2d84be812
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list