Change in ovirt-engine[master]: core: redesign MemoryStorageHandler to be a singleton

tnisan at redhat.com tnisan at redhat.com
Tue Jun 2 12:33:04 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: redesign MemoryStorageHandler to be a singleton
......................................................................


core: redesign MemoryStorageHandler to be a singleton

This patch redesignes MemoryStorageHandler to be a singleton so it
would be more testable.

Change-Id: Iba82cdb2c7c269bd482c5ad3fb0ca79ba1ade6af
Bug-Url: https://bugzilla.redhat.com/1186230
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java
5 files changed, 23 insertions(+), 14 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Verified; Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/40434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba82cdb2c7c269bd482c5ad3fb0ca79ba1ade6af
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list