Change in ovirt-engine[master]: webadmin, userportal: ClientStorage improvements

[vszocs at redhat.com]

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: ClientStorage improvements
......................................................................


webadmin,userportal: ClientStorage improvements

1. All key/value pairs persisted through ClientStorage interface
   now use application-specific key prefix to avoid clashes between
   WebAdmin vs. UserPortal instances running on the same browser
   (but not necessarily at the same time) where one instance might
   read data originally persisted by another instance.

   Example key names:
     ENGINE_WebAdmin_MyKey
     ENGINE_UserPortal_MyKey

2. ClientStorageImpl behavior modified as following:
   * get{Local,Session}Item -- first use prefixed key, if missing
     fall back to un-prefixed key for backwards compatibility
   * set{Local,Session}Item -- use prefixed key (only)

3. Removed unused ClientStorage interface methods:
   * removeLocalItem
   * removeSessionItem

4. Added ClientStorageImplTest.

5. In UserPortal SystemModule, removed unnecessary GIN bindings.

Change-Id: Iaef8f72feec5dd083fbe4cc962a222dce4f7a99f
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorage.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorageImpl.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorageKeyPrefix.java
A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/system/ClientStorageImplTest.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java
6 files changed, 193 insertions(+), 37 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Verified; Looks good to me, but someone else must approve
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/41404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaef8f72feec5dd083fbe4cc962a222dce4f7a99f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org