Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Always use UTF-8 for encoding text

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Jun 3 12:21:23 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: sdk: Always use UTF-8 for encoding text
......................................................................


sdk: Always use UTF-8 for encoding text

Currently there are several places in the SDK where XML documents are
converted to text without specifying the character set to use. In this
situation the underlying HTTP library will select a character set that
may not match the character set declared in the header of the XML
document, resulting in incorrectly encoded documents. To solve this
issue this patch changes the SDK so that it always specify explicitly
the UTF-8 character set, when generating the XML documents and when
encoding them.

Change-Id: I560e3b96756ec1ffa1bf0169ba116edc18fa9844
Bug-Url: https://bugzilla.redhat.com/1223186
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/HttpResponseHelper.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/SerializationHelper.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/StringUtils.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBroker.java
4 files changed, 13 insertions(+), 4 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/41141
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I560e3b96756ec1ffa1bf0169ba116edc18fa9844
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list