Change in ovirt-engine[master]: core: fix permissions check on import vm

ahadas at redhat.com ahadas at redhat.com
Wed Jun 10 13:03:36 UTC 2015


Arik Hadas has submitted this change and it was merged.

Change subject: core: fix permissions check on import vm
......................................................................


core: fix permissions check on import vm

Changing import VM commands to extend VmCommand, caused them not to use
the proper permission objects. This patch restore the permission object
- in ImportVmCommandBase we use the storage domains that the disks will
  be copied to
- in ImportVmCommand we also use the storage domain that the disks are
  originally reside on

Change-Id: If0ebed256f1f7dc90d9472582adbf827ff84d421
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java
2 files changed, 18 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Looks good to me, but someone else must approve
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/40572
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0ebed256f1f7dc90d9472582adbf827ff84d421
Gerrit-PatchSet: 43
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list