Change in ovirt-engine-sdk[master]: sdk: Don't add headers without value

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Jun 10 14:27:06 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: sdk: Don't add headers without value
......................................................................


sdk: Don't add headers without value

Currently the SDK adds to the request all the headers passed from the
generated broker classes, including those headers with no value. The
result is headers that have the string "None" as the value, for example:

  Content-type: None
  Correlation-Id: None

These headers, in particular the "Content-type: None" header are then
rejected by the application server.

This behaviour is a regression introduced by the change tht replaced the
Pyhton HTTP module with PycURL, and only affects the 3.6 branck.

To avoid this issue this patch changes the SDK so that it will not add
the headers that don't have a value.

Change-Id: I1ebbfc2197bbfdaf3765460b3ff68765065b7696
Bug-Url: https://bugzilla.redhat.com/1227655
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/ovirtsdk/infrastructure/connectionspool.py
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me; Ready for merge; Passed CI tests
  Jenkins CI: Verified



-- 
To view, visit https://gerrit.ovirt.org/41880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ebbfc2197bbfdaf3765460b3ff68765065b7696
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list