Change in ovirt-engine[master]: webadmin: removing redundant check

alkaplan at redhat.com alkaplan at redhat.com
Thu Jun 11 05:42:36 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: removing redundant check
......................................................................


webadmin: removing redundant check

Findbugs complain about the test, as it will always be true if the
object is not null. So, we can just return the object, as it will either
be null, or VDS.

Change-Id: Ia69328ecd3be647ce72ef21f4aeb073d95072596
Signed-off-by: Oved Ourfali <oourfali at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved
  Jenkins CI: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/42165
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia69328ecd3be647ce72ef21f4aeb073d95072596
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list