Change in ovirt-engine[master]: core:(2) Editing of template version for pools

ofrenkel at redhat.com ofrenkel at redhat.com
Thu Jun 11 16:03:30 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: core:(2) Editing of template version for pools
......................................................................


core:(2) Editing of template version for pools

--This patch includes the commands and queries changes

The feature will allow a user to change a template version for an
existing Pool.

The main issues handled are:
- Pool object - added support for changing of the template field.
- Frontend - Added support for editing of this field and introduced
some limitations to avoid non-supported behaviors.
- UpdateVmVersion Command - added support for any template version.
- Pools commands - Until now pools haven't supported changes affecting the
actual VMs and some logic that depended on this assumption needed change.
- Running VMs - Changes were required in the next-run logic on multiple locations.

Change-Id: I2249cfea12ffbab008c162d52928df782f5f9d85
Bug-Url: https://bugzilla.redhat.com/1140569
Signed-off-by: Eldan Shachar <eshachar at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllPoolVmsQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLatestTemplateInChainQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmDataByPoolIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmDataByPoolNameQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByBaseTemplateIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DetachUserFromVmFromPoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmVersionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
15 files changed, 411 insertions(+), 73 deletions(-)

Approvals:
  Eldan Shachar: Verified
  Jenkins CI: Verified; Looks good to me, but someone else must approve
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/36508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2249cfea12ffbab008c162d52928df782f5f9d85
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list