Change in ovirt-engine[master]: core: dont check vmManager timestamp if it wasnt set

ofrenkel at redhat.com ofrenkel at redhat.com
Thu Jun 18 09:07:59 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: core: dont check vmManager timestamp if it wasnt set
......................................................................


core: dont check vmManager timestamp if it wasnt set

when engine starts, the first monitoring cycle will always skip the
current running vms because the VmManager objects for them are created
only after fetching the information from vdsm, so the time check will
always fail.

the check is changed to verify that some value has been set,
and if not it considered ok to do the monitoring cycle.

Change-Id: I6ced6416b4015b86aeb75371224ad68dc1f5b74c
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
2 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ced6416b4015b86aeb75371224ad68dc1f5b74c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list