Change in ovirt-engine[master]: core: Make regular user owner of VMs he created

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core: Make regular user owner of VMs he created
......................................................................


core: Make regular user owner of VMs he created

If regular user has permission to create a VM and does this through
webadmin UI (having also ReadOnlyAdmin role) or REST API with
Filter: false, he doesn't get ownership for this VM by default. This is
OK for admin users, but non-admin users will effectively loose access to
their VMs.

To fix this, additional check is made for webadmin UI users and REST API
with Filter: false users, checking if they have permission to manage the
VM being created. If not, this permission is added for them.

Change-Id: I7e814ab024ceed63e3ec7fce82ca574fa5be1c8b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121144
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Looks good to me, but someone else must approve
  Shmuel Leib Melamud: Verified
  Omer Frenkel: Looks good to me, approved; Passed CI tests
  Michal Skrivanek: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/42392
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e814ab024ceed63e3ec7fce82ca574fa5be1c8b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud at redhat.com>
Gerrit-Reviewer: automation at ovirt.org