Change in ovirt-engine[master]: core: prevent npe when vm disappears from vdsm

ahadas at redhat.com ahadas at redhat.com
Thu Jun 18 22:34:55 UTC 2015


Arik Hadas has submitted this change and it was merged.

Change subject: core: prevent npe when vm disappears from vdsm
......................................................................


core: prevent npe when vm disappears from vdsm

VmInternalData is set to null for a VM that disappeared from the host
and is not reported by VDSM. In this case the VM should be monitored in
the getAllStats cycle, so returning 'true' in
VdsManager#shouldUpdateVmStatus and prevent NPE.

Change-Id: I048866e03ae8b25d5b67e6b1be78046166c92217
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Looks good to me, but someone else must approve; Passed CI tests
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/42468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I048866e03ae8b25d5b67e6b1be78046166c92217
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list