Change in ovirt-engine[master]: webadmin: Form panel label/value width

awels at redhat.com awels at redhat.com
Fri Jun 19 19:10:05 UTC 2015


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Form panel label/value width
......................................................................


webadmin: Form panel label/value width

- The form panel label width and value width were always at
  50%/50%. So if you made one column the width of the entire
  available space, the spacing between the label and value
  would be off. So one would decrease the width of the panel.
  However this can cause some cut offs for really large values,
  like in the path of the storage general panel.
  This patch allows the developer more control over how the
  label/value are distributed allowing for larger columns to not
  have strange spacing.

Change-Id: I43f35cd46116b8d386b86383e97fca9862e7d479
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230723
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java
3 files changed, 33 insertions(+), 23 deletions(-)

Approvals:
  Alexander Wels: Verified
  Jenkins CI: Looks good to me, but someone else must approve; Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43f35cd46116b8d386b86383e97fca9862e7d479
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list