Change in ovirt-engine[master]: core: move cached info about last event to vm-manager

ahadas at redhat.com ahadas at redhat.com
Sun Jun 21 08:25:55 UTC 2015


Arik Hadas has submitted this change and it was merged.

Change subject: core: move cached info about last event to vm-manager
......................................................................


core: move cached info about last event to vm-manager

The caching of the timestamp of the last event we got per-VM is moved to
VmManager instead of being in VdsManager:
1. It is a value per-VM, thus VmManager is more appropriate for that
than having it in VdsManager
2. When saving the host we got the last event from with the timestamp we
don't need to reset the timestamp when the VM is moving between hosts
(in the previous state it looks like we missed the case of rerun for
RunVm for example)

Change-Id: I9ee4470d43e3d4690343a0fdc23df2e1fdddbf8e
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
4 files changed, 33 insertions(+), 34 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/42469
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ee4470d43e3d4690343a0fdc23df2e1fdddbf8e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list