Change in ovirt-engine[master]: core: Clean up addInjectionsToPerClusterObjects()

amureini at redhat.com amureini at redhat.com
Tue Jun 23 13:41:52 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Clean up addInjectionsToPerClusterObjects()
......................................................................


core: Clean up addInjectionsToPerClusterObjects()

Changed iterating over a temporary object with a direct iteration on the
entrySet(). This technique has several advantages:

1. It's more readable.
2. It's shorter.
3. It avoids copying the entire map just to re-initialize it.

Change-Id: Ic08df6c9c798d0b6a2072825a0a64ff2b3d722e6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Allon Mureinik: Verified; Passed CI tests
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42624
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic08df6c9c798d0b6a2072825a0a64ff2b3d722e6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list