Change in ovirt-engine[master]: core: Don't mock default behavior

amureini at redhat.com amureini at redhat.com
Wed Jun 24 16:28:36 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Don't mock default behavior
......................................................................


core: Don't mock default behavior

Removed mocking the behavior of returning a null StorageDomainStatic
for any id. This is the default behavior of Mockito, and explicitly
stating it is not only useless but also confusing.

Change-Id: Ief5586e53b3e5f78c414e5729b4fe4527011c460
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/42828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief5586e53b3e5f78c414e5729b4fe4527011c460
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list