Change in ovirt-engine[master]: core: Remove redundant "constants"

amureini at redhat.com amureini at redhat.com
Wed Jun 24 16:28:36 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove redundant "constants"
......................................................................


core: Remove redundant "constants"

Removed the redundant WARNING_LOW_SPACE_INDICATOR and
CRITICAL_SPACE_ACTION_BLOCKER "constants". They are only used to inject
config values (via the MockConfigRule) to config values which have
names that are descriptive enough. The double declaration doesn't add
anything besides lines of code.

Change-Id: I5068bae9b3414d3ed9eb69c4cc56a703de73e58f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/42825
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5068bae9b3414d3ed9eb69c4cc56a703de73e58f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list