Change in ovirt-engine[master]: restapi: Test helper should compare correctly two nulls

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Jun 25 12:50:05 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Test helper should compare correctly two nulls
......................................................................


restapi: Test helper should compare correctly two nulls

Currently the method that is used to compare expected and actual
arguments doesn't work correctly when cpmparing two new values, and it
may throw a NPE. This patch avoids that NPE using the Objects.equals
method.

Change-Id: I22317f4dd1e5f81ce0b42db27c63b8689519e6e3
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Ori Liel: Looks good to me, approved
  Juan Hernandez: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/42822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22317f4dd1e5f81ce0b42db27c63b8689519e6e3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list