Change in ovirt-engine[master]: webadmin: re-fix for new Host/Cluster dropdown

awels at redhat.com awels at redhat.com
Tue Jun 30 19:29:07 UTC 2015


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: re-fix for new Host/Cluster dropdown
......................................................................


webadmin: re-fix for new Host/Cluster dropdown

- Fixed a npe for a cluster without a DC.
- Fixed issue where calling setSelected on the LisBox manually would
  not update the associated lable for the DC.
- Cleaned up some formatting on HostPopupView.
- Fixed issue where editing a host would not display the right cluster
  data center combination.
- Made sure that if the value can be set, it is set before calling
  setAcceptableValues. This solves the issue with the new domain dialog

Change-Id: I302554888a272dd47587a33f9b5137a997d7ebd1
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBox.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
6 files changed, 58 insertions(+), 26 deletions(-)

Approvals:
  Alexander Wels: Verified
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I302554888a272dd47587a33f9b5137a997d7ebd1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list