Change in ovirt-engine[master]: core: long method refactor

masayag at redhat.com masayag at redhat.com
Tue Mar 10 07:08:44 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: long method refactor
......................................................................


core: long method refactor

extracted duplicates into methods.

this code is more readable with each pair on one line. Can be better
if refactored into class, if one doing CR is ok with that, I can do
it.
Comment: isn't it an error, ending with coma?

Change-Id: I832bc8c7e8bdfb2948f2137922e738fc6e702e59
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 31 insertions(+), 30 deletions(-)

Approvals:
  Martin Mucha: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/29588
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I832bc8c7e8bdfb2948f2137922e738fc6e702e59
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976 at gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list