Change in ovirt-engine[master]: engine: Updating the maintenance_reason on MaintenanceNumber...

alkaplan at redhat.com alkaplan at redhat.com
Tue Mar 10 08:19:56 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Updating the maintenance_reason on MaintenanceNumberOfVdssCommand
......................................................................


engine: Updating the maintenance_reason on MaintenanceNumberOfVdssCommand

SetVdsStatusVdsCommand gets the maintenanceReason as a parameter and stores
it in the db. If the reason is not set, a null will be stored.

When the maintenance command is executed the reason (if there is one) is
passed to SetVdsStatusVdsCommand.
Since all the vds status changes are done via SetVdsStatusVdsCommand, when
the status of the vds is changed to another status the maintenance reason
will be nullified (since other places that executes SetVdsStatusVdsCommand
doesn't pass maintenanceReason via the parameters).

Change-Id: If1ab2e0b3e2cc154d14282bc38b158b0b4d195fe
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceNumberOfVdssParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVdsStatusVDSCommandParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
8 files changed, 39 insertions(+), 5 deletions(-)

Approvals:
  Alona Kaplan: Verified
  Liran Zelkha: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1ab2e0b3e2cc154d14282bc38b158b0b4d195fe
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list