Change in ovirt-hosted-engine-setup[master]: packaging: setup: handling previously generated answerfile w...

sbonazzo at redhat.com sbonazzo at redhat.com
Tue Mar 10 10:23:42 UTC 2015


Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: setup: handling previously generated answerfile with wrong types
......................................................................


packaging: setup: handling previously generated answerfile with wrong types

Till 3.5 we were threating some VM parameters as integer
is read from the OVF file and as string if manually entered.
It was not really an issue cause we were than generating
a temporary configuration fail for vdsClient usage with an
implicit string conversion.
Now we are using vdsclient and so we have to use the correct
type and so we need also to handle answerfile generated from
previously release where the type could be not correct.

Change-Id: I07c296c4ef92430f03a5b23a2a996db9c643a9c5
Bug-Url: https://bugzilla.redhat.com/1198725
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/cpu.py
M src/plugins/ovirt-hosted-engine-setup/vm/memory.py
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Simone Tiraboschi: Verified



-- 
To view, visit https://gerrit.ovirt.org/38417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07c296c4ef92430f03a5b23a2a996db9c643a9c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list