Change in ovirt-engine[ovirt-engine-3.5.2]: core: Set Guid.EMPTY to Permissions.id by default

oourfali at redhat.com oourfali at redhat.com
Wed Mar 11 11:24:51 UTC 2015


Oved Ourfali has submitted this change and it was merged.

Change subject: core: Set Guid.EMPTY to Permissions.id by default
......................................................................


core: Set Guid.EMPTY to Permissions.id by default

Sets Guid.EMPTY to Permissions.id by default when creating new instance
because:

1. Guid.newGuid() cannot be used in frontend code, because it call
   UUID.randomUUID() which is not supported in GWT

2. In AddPermission command there's always assigned Guid.newGuid() into
   Permissions.id for created permissions.

Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821
Bug-Url: https://bugzilla.redhat.com/1195119
Signed-off-by: Martin Perina <mperina at redhat.com>
(cherry picked from commit f3c71e1197a0ea1906539162ae19057ff4021b3d)
(cherry picked from commit f877373820ba64d39497f23f39015fe186a7bff9)
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38569
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list