Change in ovirt-engine[master]: core: Could not clear external job

masayag at redhat.com masayag at redhat.com
Thu Mar 12 11:27:42 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: Could not clear external job
......................................................................


core: Could not clear external job

This patch fixes two problems when attempting to clear an external job
from the API

1) The parameters in the UpdateJob SP did not match the parameters sent
from the DAO
2) The command did not set the return value when succeeded, causing the
whole command to rollback

Change-Id: Ie838897d389ad9bf253cfe3edc8a363f73d584bb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156055
Signed-off-by: emesika <emesika at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java
M packaging/dbscripts/job_sp.sql
2 files changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Eli Mesika: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie838897d389ad9bf253cfe3edc8a363f73d584bb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list