Change in ovirt-engine[master]: webadmin: StorageListModel fix for Coveritiy scan.

derez at redhat.com derez at redhat.com
Thu Mar 12 12:28:35 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: StorageListModel fix for Coveritiy scan.
......................................................................


webadmin: StorageListModel fix for Coveritiy scan.

A coveritiy scan have found a null dereference in a recent
StorageListModel patch. Although the scenerio tested can never
happen, this patch updates the code to still check nullity and
prevent any chance of NullPointerException resulting from another
potential bug.

Change-Id: I028eaeb0c6f579cedaf135692b3c23bcdda0d0b9
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/38642
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I028eaeb0c6f579cedaf135692b3c23bcdda0d0b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list