Change in ovirt-engine[master]: core: Fix unreachable code in FenceAgentDaoDbFacadeImpl

awels at redhat.com awels at redhat.com
Thu Mar 19 12:03:09 UTC 2015


Alexander Wels has submitted this change and it was merged.

Change subject: core: Fix unreachable code in FenceAgentDaoDbFacadeImpl
......................................................................


core: Fix unreachable code in FenceAgentDaoDbFacadeImpl

Fixes unreachable code in FenceAgentDaoDbFacadeImpl reported by
Coverity. Method ResultSet.getBoolean() return primitive type boolean so
there's no sense in casting it into object Boolean and check for null.

Change-Id: Ie8c1f2d53d2d5b65c67f51b969a9ccbc49fdb11e
Signed-off-by: Martin Perina <mperina at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceAgentDaoDbFacadeImpl.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Martin Peřina: Verified
  Alexander Wels: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38925
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8c1f2d53d2d5b65c67f51b969a9ccbc49fdb11e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list