Change in ovirt-engine[master]: webadmin: fix can't change session row selection

alkaplan at redhat.com alkaplan at redhat.com
Tue Mar 24 09:13:18 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: fix can't change session row selection
......................................................................


webadmin: fix can't change session row selection

Fix for selection cannot be changed in the session main tab.
Introducing UserSession class that would serve as DTO for sessions data.
That is needed in order to prevent sending session-id out of the engine
and defining equals&hashCode functionality,
which isn't based on session-id.

Change-Id: Ib781d99009adab519be919cedbc76854a255af7f
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserSession.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SessionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TerminateSessionsModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/SessionModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabSessionPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabSessionView.java
12 files changed, 118 insertions(+), 55 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/38943
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib781d99009adab519be919cedbc76854a255af7f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list