Change in ovirt-engine[master]: packaging: setup: raising on invalid application mode values

sbonazzo at redhat.com sbonazzo at redhat.com
Tue Mar 31 12:32:05 UTC 2015


Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: setup: raising on invalid application mode values
......................................................................


packaging: setup: raising on invalid application mode values

It was treating every invalid application mode values as
virtOnly. Checking it for a more consistent behavior.
The default value for ApplicationMode at DB creation is
AllModes = 255; making it more explicit.

Change-Id: Ic47e171ddc76a9881e4a915f62dbae762a72f9f8
Bug-Url: https://bugzilla.redhat.com/1149575
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py
1 file changed, 26 insertions(+), 20 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Simone Tiraboschi: Verified
  oVirt Jenkins CI Server: Looks good to me, but someone else must approve
  Sahina Bose: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/39094
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic47e171ddc76a9881e4a915f62dbae762a72f9f8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list