Change in ovirt-engine[master]: core: NPE fix in clone image from snapshot

amureini at redhat.com amureini at redhat.com
Sun May 10 15:02:54 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: NPE fix in clone image from snapshot
......................................................................


core: NPE fix in clone image from snapshot

NPE is thrown from AddVmFromSnapshotCommand's CDA. This is caused
because destStorages is filled with its domains only in the super's
CDA- which is being called at the end of the function.

This patch puts the call to super.CDA before the usage of destStorages.

* Later on, this will be refactored, this patch is a fast fix for 3.5.3
build.

Change-Id: Ib1c412298c017bd1dad6ee1248933907139d82e3
Bug-Url: https://bugzilla.redhat.com/1215845
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Amit Aviram: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40662
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1c412298c017bd1dad6ee1248933907139d82e3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list