Change in ovirt-engine[master]: webadmin : Fix ClassCastException in datetimebox widget

awels at redhat.com awels at redhat.com
Mon May 11 18:20:43 UTC 2015


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin : Fix ClassCastException in datetimebox widget
......................................................................


webadmin : Fix ClassCastException in datetimebox widget

This patch fixes the ClassCastException obtained from
recently introduced AssetProvider#addStateUpdateHandler().
The issue is with this patch it tries to cast the
GwtBootstrapDateTimePicker to widget and hence fails
this was fixed by making it extend from Composite
which in turn extends from Widget class and casting
from derived to base wouldn't be a problem.

Change-Id: Ib23eaab6160c814c26cd6a0566263cabed752e3e
Signed-off-by: Anmol Babu <anbabu at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GwtBootstrapDateTimePicker.java
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  anmolbabu: Verified



-- 
To view, visit https://gerrit.ovirt.org/40783
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib23eaab6160c814c26cd6a0566263cabed752e3e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list