Change in ovirt-engine[master]: core: Save RNG device when VM is running

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core: Save RNG device when VM is running
......................................................................


core: Save RNG device when VM is running

Added missing functionality to detect changes of RNG device properties
when VM is running and to save/restore them to/from NEXT_RUN snapshot.
For this purpose Optional<T> class was added to
VmManagementParametersBase. This class combines data for the device that
needs to be updated with a flag that switches the update on/off. This
change makes possible to use @EditableDeviceOnVmStatusField annotation
for rngDevice field and to combine rngDevice update with other device
updates in a single list. Optional<T> class may be used as well for
other fields in VmManagementParametersBase that use the same pattern.
Watchdog is one of them.

Change-Id: If9aa41b0cacd77120b002123d8e196e215e20fdc
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
7 files changed, 167 insertions(+), 70 deletions(-)

Approvals:
  Shmuel Leib Melamud: Verified
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9aa41b0cacd77120b002123d8e196e215e20fdc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org