Change in ovirt-engine[master]: core: configurable parent for create image template

ahadas at redhat.com ahadas at redhat.com
Wed May 27 13:06:19 UTC 2015


Arik Hadas has submitted this change and it was merged.

Change subject: core: configurable parent for create image template
......................................................................


core: configurable parent for create image template

We used to assume that CreateImageTemplateCommand is called from
AddVmTemplateCommand, so the parent command was hard-coded in
CreateImageTemplateCommand.

This patch modifies CreateImageTemplateCommand such that it will take
the parent command from the parameters instead. This change is needed
for adding commands that extend AddVmTemplateCommand such as add
template from snapshot.

Change-Id: If81b0e84e32674c094a2fbeaf1a2e26f2296a7f3
Bug-Url: https://bugzilla.redhat.com/1003492
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Looks good to me, but someone else must approve
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified

Objections:
  Jenkins CI: Fails



-- 
To view, visit https://gerrit.ovirt.org/41412
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If81b0e84e32674c094a2fbeaf1a2e26f2296a7f3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list