Change in ovirt-engine[master]: core: Make Singletons also BackendService and load them

rgolan at redhat.com rgolan at redhat.com
Thu May 28 07:51:48 UTC 2015


Roy Golan has submitted this change and it was merged.

Change subject: core: Make Singletons also BackendService and load them
......................................................................


core: Make Singletons also BackendService and load them

- Use CDI programatic API to fetch instances, which initializes them if
  not exist.
- use internal loadService method to get a concise, clean and constant
  manner of service loading
- TODO every service maintainer/creator must follow the same loading
  manner unless special handling needed.

Change-Id: I542278b8511def02fa1b93bdfb0703c7ff2dd462
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
5 files changed, 41 insertions(+), 30 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, approved
  Jenkins CI: Verified; Looks good to me, but someone else must approve
  Roy Golan: Verified
  Liran Zelkha: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/41037
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I542278b8511def02fa1b93bdfb0703c7ff2dd462
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list