Change in ovirt-engine[ovirt-engine-3.6.0]: core: fixing NPE when importing nic with null valued mac

tnisan at redhat.com tnisan at redhat.com
Sun Nov 1 14:48:18 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: fixing NPE when importing nic with null valued mac
......................................................................


core: fixing NPE when importing nic with null valued mac

Error fix of bug introduced by:
779d378e2b51510b54950e8f1f384382bfc956a5

In former code (prior to mentioned erroneous patch) was null valued
mac used to gather nics from db, which indeed return no nics, thus no
match was found and true returned. With removal of this call error
was made; when mac of passed in nic is null, true must be returned.

Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b
Bug-Url: https://bugzilla.redhat.com/1270003
Signed-off-by: Martin Mucha <mmucha at redhat.com>
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 10 insertions(+), 5 deletions(-)

Approvals:
  Alona Kaplan: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47933
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.0
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list