Change in ovirt-engine[master]: engine: Bonding modes 0, 5 and 6 should be avoided for VM ne...

alkaplan at redhat.com alkaplan at redhat.com
Thu Nov 5 11:58:51 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Bonding modes 0, 5 and 6 should be avoided for VM networks
......................................................................


engine: Bonding modes 0, 5 and 6 should be avoided for VM networks

Bonds with bonding modes 0, 5 and 6 should be prohibited from
having vm networks.
This patch modifies the HostSetupNetworkValidator not to allow to
attach a vm network to a bond with such bonding options, and also
prohibits to change the bonding options to such if a vm network
is attached.

Change-Id: Ie83b633b36de7985df42bc019e602d5f2fbd25dc
Bug-Url: https://bugzilla.redhat.com/1094842
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 234 insertions(+), 2 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Alona Kaplan: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie83b633b36de7985df42bc019e602d5f2fbd25dc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list