Change in ovirt-engine[master]: backend: call GetDeviceList when specifying host in AddDiskC...

amureini at redhat.com amureini at redhat.com
Tue Nov 10 13:03:26 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: backend: call GetDeviceList when specifying host in AddDiskCommand
......................................................................


backend: call GetDeviceList when specifying host in AddDiskCommand

When creating a direct lun, if the host id is passed through the
parameters to AddDiskCommand, GetDeviceList will be called to get the
lun from vdsm.
This way, passing the host id will cause AddDiskCommand to store the up
to date details of the lun in the db.

Change-Id: I27c3b6ba5699e259ede693bf48717687cff3eecb
Bug-Url: https://bugzilla.redhat.com/1275649
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
4 files changed, 75 insertions(+), 74 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved; Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/48285
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27c3b6ba5699e259ede693bf48717687cff3eecb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list